save matrix command works sometimes and sometimes gives error

Question

Priyank Anilchandra Dhyani il 21 Lug 2023

0
Link

Link diretto a questa domanda

https://it.mathworks.com/matlabcentral/answers/1999203-save-matrix-command-works-sometimes-and-sometimes-gives-error

Commentato: Priyank Anilchandra Dhyani il 27 Lug 2023

Hello,

I have been running a script that reads in data from multiple files, add them to a structure, and then save it. The code works just fine. But someitmes, it would give me an error.

Error using save

Unable to write file ColdFlow\Grid Resolution_ReOrder\MultitoSingleBlock\OutputFiles\OutputFilesForVisualization\Bfine.mat: Invalid argument.

Error in CollectData (line 110)

save(strcat(FolderName,'/',Case,'.mat'),'Structure','-v7.3')

If I rerun the script again, the error won't show up.

I do run this script on google drive, when I leave out multiple cases to run overnight, this haapens. I am not sure if this is a sync related issue, or matlab related issue. How do I fix it? I need a relaible code, than I can leave running for days to generate data.

6 Commenti
Mostra 4 commenti meno recentiNascondi 4 commenti meno recenti

Bruno Luong il 23 Lug 2023

Modificato: Bruno Luong il 23 Lug 2023

Apri in MATLAB Online

@Priyank Anilchandra Dhyani if I was you I would never use

addpath(strcat(pwd,'\',FolderName))

This is not robust as pwd can change, and the order of the path matters, multiple files with the same name can be found of different path,etc...

I'm not 100% sure if you have to add the absolute path of the file or the rootpath where the relative path is based on in the search path (meaning pwd).

More importantly I'm not sure how MATLAB search path would behave if for some reason the Google drive losts sync and strcat(pwd,'\',FolderName) become temporary invalid.

If you want to write robust code, this is NOT the way you should do.

I would reduce as much as possible program, context, config, etc.. that depend on google drive, mainly the only thing that remain is the file that you try to read and write.

Priyank Anilchandra Dhyani il 23 Lug 2023

@Bruno Luong I totally agree with you, this can potentially increase a lot of problems in future to trace back the errrors. I will try to minimize the scripts dependency on google drive's sync.

Thank you very much!

Accedi per commentare.

Accedi per rispondere a questa domanda.

Answer 1

Jan il 22 Lug 2023

0
Link

Link diretto a questa risposta

https://it.mathworks.com/matlabcentral/answers/1999203-save-matrix-command-works-sometimes-and-sometimes-gives-error#answer_1276993

Avoid strcat to create a folder name, but use fullfile, which cares for the correct separators.

A try/catch block is the way to go to catch and handle errors.

3 Commenti
Mostra 1 commento meno recenteNascondi 1 commento meno recente

Priyank Anilchandra Dhyani il 22 Lug 2023

Apri in MATLAB Online

Thanks for your reply. Is there a fucntion similar to strcat? I need that statement, because I have made a script that can run across multiple directories. I need to stich it together with pwd. I have attache a part fo the script.

I am not familiar with try/catch blocks. I will look into it. Thanks!

function CollectData(FolderName,Case)  %Input in string
tic
% Following fours lines for path specification is to ensure that the script
% is running in the desired folder only, and all other folder paths are
% removed. 
restoredefaultpath
addpath(pwd)
cd ..
addpath(strcat(pwd,'\',FolderName))
fprintf('current path is %s\n',strcat(pwd,'\',FolderName))
if isfile(strcat(pwd,'\',FolderName,'\ReyAvg.tec'))  
    fprintf('Reading XYZ data ...\n')
    Structure.XYZ=ReadTecPlotDataXYZ('ReyAvg.tec');               %Also read the XYZ Data
    fprintf('... Finished!\n')
    fprintf('Reading ReyAvg data ...\n')
    Structure.ReyAvg=ReadTecplotDataReyAvg('ReyAvg.tec');
    fprintf('... Finished!\n')
else 
    fprintf('RevAvg.tec not found\n')
end
fprintf('Saving Structure ...\n')
save(strcat(FolderName,'/',Case,'.mat'),'Structure','-v7.3')

Jan il 25 Lug 2023

Apri in MATLAB Online

"Is there a fucntion similar to strcat?" - I've suggested fullfile already.

Instead of changing the path, it is safer to work with absolute path names. Replace:

restoredefaultpath
addpath(pwd)
cd ..
addpath(strcat(pwd,'\',FolderName))

by

FullFolder = fullfile(pwd, FolderName);
if isfile(fullfile(FullFolder, 'ReyAvg.tec'))
    ...
end

Priyank Anilchandra Dhyani il 27 Lug 2023

@Jan, I didnt realise fullfile is a function that I can use. Thank you very much, I will makes those changes!

Accedi per commentare.

save matrix command works sometimes and sometimes gives error

6 Commenti
Mostra 4 commenti meno recentiNascondi 4 commenti meno recenti

Risposte (1)

3 Commenti
Mostra 1 commento meno recenteNascondi 1 commento meno recente

Vedere anche

Categorie

Tag

Prodotti

Release

Community Treasure Hunt

save matrix command works sometimes and sometimes gives error

6 Commenti Mostra 4 commenti meno recentiNascondi 4 commenti meno recenti

Risposte (1)

3 Commenti Mostra 1 commento meno recenteNascondi 1 commento meno recente

Vedere anche

Categorie

Tag

Prodotti

Release

Community Treasure Hunt

6 Commenti
Mostra 4 commenti meno recentiNascondi 4 commenti meno recenti

3 Commenti
Mostra 1 commento meno recenteNascondi 1 commento meno recente